Skip to content

Rewrite ghcr.io in devcontainer features to use the pull through cache#361

Merged
pantherman594 merged 1 commit intomasterfrom
ghcr-cache
Apr 3, 2026
Merged

Rewrite ghcr.io in devcontainer features to use the pull through cache#361
pantherman594 merged 1 commit intomasterfrom
ghcr-cache

Conversation

@pantherman594
Copy link
Copy Markdown
Contributor

@pantherman594 pantherman594 commented Apr 3, 2026

Use our pull through cache for devcontainer features so we don't run into ghcr.io's aggressive rate limiting.

We should do this at runtime after pulling the git repo, rather than saving them to this repository, since it could muddy dependency order resolution if other features are added. For example, our workbench-tools feature has

  "installsAfter": [
    // ...
    "ghcr.io/devcontainers/features/conda",
    // ...
  ]

if we rewrote this to

  "installsAfter": [
    // ...
    "us-central1-docker.pkg.dev/workbench-app-cache/ghcr-cache/devcontainers/features/conda",
    // ...
  ]

and someone added ghcr.io/devcontainers/features/conda to their custom app, workbench-tools could potentially get installed before conda since installsAfter matches the feature by repository URL.

@pantherman594 pantherman594 marked this pull request as ready for review April 3, 2026 17:21
@pantherman594 pantherman594 requested review from a team as code owners April 3, 2026 17:21
@pantherman594 pantherman594 merged commit 6b03be5 into master Apr 3, 2026
13 of 15 checks passed
@pantherman594 pantherman594 deleted the ghcr-cache branch April 3, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants