Skip to content

Overhaul buildscripts#54

Draft
Timtaran wants to merge 2 commits into
velthoric:masterfrom
Timtaran:buildscript-update
Draft

Overhaul buildscripts#54
Timtaran wants to merge 2 commits into
velthoric:masterfrom
Timtaran:buildscript-update

Conversation

@Timtaran
Copy link
Copy Markdown
Contributor

@Timtaran Timtaran commented May 3, 2026

  • Updates gradle to 9.4.1 (preparation for the transition to stonecutter)
  • Adds maven publishing to nightly and release actions

@Timtaran Timtaran force-pushed the buildscript-update branch from 0c27256 to 2b083fd Compare May 3, 2026 12:08
@Timtaran Timtaran marked this pull request as ready for review May 3, 2026 13:46
@Timtaran Timtaran force-pushed the buildscript-update branch from 0341275 to bdbb44d Compare May 3, 2026 13:50
@Timtaran
Copy link
Copy Markdown
Contributor Author

Timtaran commented May 3, 2026

I can't say that I've managed to fit it into the current buildSrc as I wanted first, but it might be a suitable solution.

Nightly build publishing works fine, but I haven't tested release one.

Following github secrets should be set:
MAVEN_RELEASES_REPO - repo uri for releases
MAVEN_SNAPSHOTS_REPO - repo uri for nightly builds
MAVEN_USER
MAVEN_TOKEN

@xI-Mx-Ix
Copy link
Copy Markdown
Member

xI-Mx-Ix commented May 3, 2026

Thanks for the PR! Could you revert the version bump? I want to wait until the actual release. Also, please keep the current Gradle version for now as I’d rather update it once we integrate Stonecutter.

@Timtaran
Copy link
Copy Markdown
Contributor Author

Timtaran commented May 3, 2026

Thanks for the PR! Could you revert the version bump? I want to wait until the actual release. Also, please keep the current Gradle version for now as I’d rather update it once we integrate Stonecutter.

I believe versions should be bumped after the past release because there is -SNAPSHOT (versions before release) and releases itself.
I also don't see problem with gradle update if everything work fine, but I will revert it in a couple minutes.

@Timtaran
Copy link
Copy Markdown
Contributor Author

Timtaran commented May 3, 2026

but yeah maybe it's better to bump it to x.y.z-SNAPSHOT instead of adding -SHAPSHOT inside nightly build

@Timtaran Timtaran marked this pull request as draft May 3, 2026 17:33
@Timtaran Timtaran force-pushed the buildscript-update branch from 607719d to 9e6de86 Compare May 6, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants