Skip to content

fix: Validate branch labels before RELAX submission#842

Merged
stevenweaver merged 1 commit intomasterfrom
bugfix/validate-relax-branch-labels
Apr 3, 2026
Merged

fix: Validate branch labels before RELAX submission#842
stevenweaver merged 1 commit intomasterfrom
bugfix/validate-relax-branch-labels

Conversation

@stevenweaver
Copy link
Copy Markdown
Member

Summary

  • Adds server-side validation that the newick tree contains {TEST} or {Test} branch labels before submitting RELAX jobs
  • Validates in both the route handler (app/routes/relax.js) and the API spawn path (app/models/relax.js)
  • Returns a descriptive error message instead of failing on the HyPhy backend

Closes #840

Test plan

  • Submit a RELAX job without selecting any test branches and verify a 400 error with a clear message is returned
  • Submit a RELAX job with properly labeled test branches and verify it proceeds normally

RELAX fails on the HyPhy backend when trees lack {TEST} branch labels.
Add validation in both the route handler and the API spawn path to
check for required branch annotations before submitting to SLURM.

Closes #840
@stevenweaver stevenweaver merged commit 2fc0cba into master Apr 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate RELAX branch labels before submission

1 participant