Potential fix for code scanning alert no. 4: Workflow does not contain permissions#87
Merged
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#87
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/vechain/thor-devkit.js/security/code-scanning/4
In general, the fix is to explicitly add a
permissionsblock that limitsGITHUB_TOKENto the minimal rights needed by the workflow. This can be done at the top level of the workflow (applies to all jobs) or per job. Here, both jobs only need to read the repo contents; Coveralls uses the token to associate coverage with the commit/PR, which typically only needscontents: readin this workflow context. We therefore add a root-levelpermissionssection withcontents: readso bothtestandfinishjobs inherit it.Concretely, in
.github/workflows/test.yml, add apermissions:block right after thename: Unit Testline. The block should specifycontents: read. No other changes to the steps or existing behavior are required. No imports or additional methods are needed since this is YAML configuration only.Suggested fixes powered by Copilot Autofix. Review carefully before merging.