Conversation
Replace @vechain/ethers@4.0.27-5 (critical GHSA-vjh7-7g9h-fjfh via elliptic@6.5.4) with ethers@^6.13.0 across all four dependent files: - src/abi.ts: replace Coder subclass with AbiCoder + processDecoded post-processor (handles address→lowercase, BigInt→string, recursive tuple/array unwrapping) - src/mnemonic.ts: Mnemonic.fromEntropy / Mnemonic.isValidMnemonic - src/hdnode.ts: HDNodeWallet.fromPhrase / fromExtendedKey / deriveChild + encodeBase58 - src/keystore.ts: encryptKeystoreJson / decryptKeystoreJson / computeAddress - tests/abi.test.ts: add 3 encodeParameters/decodeParameters coverage tests; relax one error-message assertion that was tied to v4 typo - package.json: typescript ^3→^5, @types/node ^10→^18 (TS5 Uint8Array compat)
- Replace tslint with eslint@9 + @typescript-eslint: removes deprecated tslint and migrates rules (quotes, semi, max-len for src only) - Upgrade mocha 5 → 11, nyc 14 → 18 to eliminate critical/high vulnerabilities - Add npm overrides for serialize-javascript@^7.0.4 (mocha transitive dep) - Upgrade @types/node ^10 → ^18, @types/mocha ^5 → ^10 - Auto-fix quote style across src/ and tests/ to match eslint config - Result: 23 vulnerabilities (4 critical, 11 high) → 3 low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.