fix: late release single tap in touchscreen mode to fix clicking in some games#1212
Open
AndreVto wants to merge 4 commits intoutkarshdalal:masterfrom
Open
fix: late release single tap in touchscreen mode to fix clicking in some games#1212AndreVto wants to merge 4 commits intoutkarshdalal:masterfrom
AndreVto wants to merge 4 commits intoutkarshdalal:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughOn touch up, simple taps now schedule a deferred left-click release via a delayed runnable; on touch down, any pending deferred release is flushed (cancelled and released immediately) before starting a new primary-finger down sequence. Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant TP as TouchpadView
participant H as Handler/Looper
participant I as InputInjector
User->>TP: Finger DOWN
TP->>TP: flushPendingTapRelease()
alt delayedPress pending
TP->>H: removeCallbacks(delayedPress)
TP->>I: injectRelease(ACTION_LEFT_CLICK)
TP->>TP: delayedPress = null
end
User->>TP: Finger UP (simple tap)
TP->>TP: detect tap && !movedBeyondTapThreshold
TP->>TP: delayedPress = () -> injectRelease(ACTION_LEFT_CLICK)
TP->>H: postDelayed(delayedPress, CLICK_DELAYED_TIME)
Note right of H: after delay
H->>I: invoke delayedPress -> injectRelease(ACTION_LEFT_CLICK)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/winlator/widget/TouchpadView.java`:
- Around line 774-775: A pending delayedPress Runnable may be left queued and
fire into a subsequent gesture; before assigning and posting a new delayedPress
in TouchpadView, cancel any previous one by calling
removeCallbacks(delayedPress) (if delayedPress is non-null) then assign
delayedPress = () -> injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK) and
postDelayed(delayedPress, CLICK_DELAYED_TIME); this ensures stale LEFTUP
callbacks are removed before scheduling a new tap-release.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0b3713a5-ba2f-45c9-8794-c08d764d88bc
📒 Files selected for processing (1)
app/src/main/java/com/winlator/widget/TouchpadView.java
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/com/winlator/widget/TouchpadView.java">
<violation number="1" location="app/src/main/java/com/winlator/widget/TouchpadView.java:775">
P2: Delayed single-tap release is posted without canceling prior pending release callbacks, which can emit stale/out-of-order LEFTUP events during subsequent gestures.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
app/src/main/java/com/winlator/widget/TouchpadView.java (1)
772-777:⚠️ Potential issue | 🟠 MajorDrain pending delayed release at next finger-down, not only on simple-tap UP.
At Line 772, the previous delayed release is only canceled when the next gesture also reaches this simple-tap path. A tap→drag (or tap→long-press) can still be interrupted by a stale queued
LEFTUPfiring mid-gesture.Proposed fix
@@ private void handleTsDown(MotionEvent event) { + // Flush any pending delayed tap-release from previous gesture + if (delayedPress != null) { + removeCallbacks(delayedPress); + injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK); + delayedPress = null; + } + float[] pt = XForm.transformPoint(xform, event.getX(), event.getY()); @@ if (gestureConfig.getTapEnabled() && !movedBeyondTapThreshold) { if (delayedPress != null) { // If there's a new single tap within 'CLICK_DELAYED_TIME' ms // Immediately release the previous down click removeCallbacks(delayedPress); injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK); + delayedPress = null; } moveCursorTo((int) pt[0], (int) pt[1]); injectClick(TouchGestureConfig.ACTION_LEFT_CLICK); delayedPress = () -> injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK); postDelayed(delayedPress, CLICK_DELAYED_TIME); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/java/com/winlator/widget/TouchpadView.java` around lines 772 - 777, A pending delayed release (delayedPress) is only canceled in the simple-tap UP path, which allows a queued LEFTUP to fire during subsequent gestures (tap→drag/long-press); fix by draining/canceling that pending release as soon as a new finger-down begins: inside TouchpadView's finger-down handler (e.g., the onTouchEvent / ACTION_DOWN path or onDown method) check if delayedPress != null, call removeCallbacks(delayedPress), call injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK) to immediately clear the stale press, and set delayedPress = null so no stale LEFTUP can fire mid-gesture.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/winlator/widget/TouchpadView.java`:
- Around line 780-781: The Runnable stored in delayedPress is left non-null
after it runs, causing stale-state pre-release behavior; update the lambda
assigned to delayedPress (the Runnable posted via postDelayed with
CLICK_DELAYED_TIME that calls injectRelease) to clear the field when it executes
(e.g., set delayedPress = null immediately before/after calling injectRelease)
and optionally remove any pending callbacks via removeCallbacks(delayedPress)
when cancelling, so delayedPress correctly reflects lifecycle and doesn't
trigger later pre-release logic.
---
Duplicate comments:
In `@app/src/main/java/com/winlator/widget/TouchpadView.java`:
- Around line 772-777: A pending delayed release (delayedPress) is only canceled
in the simple-tap UP path, which allows a queued LEFTUP to fire during
subsequent gestures (tap→drag/long-press); fix by draining/canceling that
pending release as soon as a new finger-down begins: inside TouchpadView's
finger-down handler (e.g., the onTouchEvent / ACTION_DOWN path or onDown method)
check if delayedPress != null, call removeCallbacks(delayedPress), call
injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK) to immediately clear the
stale press, and set delayedPress = null so no stale LEFTUP can fire
mid-gesture.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4c819887-0f81-4eb2-850e-7d01375d9857
📒 Files selected for processing (1)
app/src/main/java/com/winlator/widget/TouchpadView.java
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/com/winlator/widget/TouchpadView.java">
<violation number="1" location="app/src/main/java/com/winlator/widget/TouchpadView.java:780">
P2: `delayedPress` is used as a pending callback flag but never cleared after execution, so later taps can trigger unintended extra release events.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/winlator/widget/TouchpadView.java`:
- Around line 772-784: The delayedPress runnable can leave the left button
logically down across gestures; add a flushPendingTapRelease() helper that
checks delayedPress, calls removeCallbacks(delayedPress),
injectRelease(TouchGestureConfig.ACTION_LEFT_CLICK), and sets delayedPress =
null, and invoke flushPendingTapRelease() at the start of handleTsDown() (before
moveCursorTo()/drag logic) so any pending release is drained immediately when a
new ACTION_DOWN begins; keep the existing delayedPress creation/postDelayed and
CLICK_DELAYED_TIME behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0742a296-b038-43fe-bff6-9e39cb7c6f42
📒 Files selected for processing (1)
app/src/main/java/com/winlator/widget/TouchpadView.java
Contributor
Author
|
@Nightwalker743 let me know if you want to take this PR, I'm not too familiar with the touchscreen mode code and the bots keeps hitting my code changes lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delay the release button for the mouse click to fix single tap in Touchscreen Mode
I suspect this fixes the issue with Touchscreen Mode because a click down and up are being sent to games too quickly, likely reaching the game within the same frame window, so for example, if games do something like
then click 1 up code is never executed
should fix these bug reports:
https://discord.com/channels/1378308569287622737/1482564848477929602
https://discord.com/channels/1378308569287622737/1490005595175125002
https://discord.com/channels/1378308569287622737/1479373032379125860
Recording
Screen_Recording_20260413_231514_GameNative.mp4
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Delay the left-click release after a single tap in Touchscreen Mode so down and up aren’t sent in the same frame. If a new tap starts within the delay window, immediately release the previous click.
Written for commit 218da26. Summary will update on new commits.
Summary by CodeRabbit