gamefix: Kingdom hearts 3 (epic) gamefix#1161
gamefix: Kingdom hearts 3 (epic) gamefix#1161unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdded a new Epic-targeted game fix for Kingdom Hearts III that sets a Wine DLL override environment variable, and registered it in the GameFixesRegistry for lookup by (GameSource.EPIC, catalogId). Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
00831e2 to
ee665de
Compare
ee665de to
47dd788
Compare
Description
Fixes kingdom hearts for epic.
Recording
Nope. But numerous accounts of the fix working here:
https://discord.com/channels/1378308569287622737/1490230113042960444
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Fixes Kingdom Hearts III (Epic) launch by auto-applying a Wine DLL override and registering the game fix.
e345fdb9186645a48d30c3f85a8951dc): setWINEDLLOVERRIDES=mf=n;mfmediaengine=nviaKeyedWineEnvVarFix; added toGameFixesRegistry.Written for commit 47dd788. Summary will update on new commits.
Summary by CodeRabbit