Skip to content

gamefix: Kingdom hearts 3 (epic) gamefix#1161

Open
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:kingdom-hearts-3-gamefix
Open

gamefix: Kingdom hearts 3 (epic) gamefix#1161
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:kingdom-hearts-3-gamefix

Conversation

@unbelievableflavour
Copy link
Copy Markdown
Contributor

@unbelievableflavour unbelievableflavour commented Apr 9, 2026

Description

Fixes kingdom hearts for epic.

Recording

Nope. But numerous accounts of the fix working here:
https://discord.com/channels/1378308569287622737/1490230113042960444

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Fixes Kingdom Hearts III (Epic) launch by auto-applying a Wine DLL override and registering the game fix.

  • Bug Fixes
    • Kingdom Hearts III (Epic e345fdb9186645a48d30c3f85a8951dc): set WINEDLLOVERRIDES=mf=n;mfmediaengine=n via KeyedWineEnvVarFix; added to GameFixesRegistry.

Written for commit 47dd788. Summary will update on new commits.

Summary by CodeRabbit

  • Bug Fixes
    • Added a compatibility fix for Kingdom Hearts III on the Epic Games Store to improve launch stability and media playback (reduces issues with in-game videos and audio).
    • The fix is applied automatically for Epic installations so users don’t need any manual configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5ddac724-1253-4da6-ae58-18453a536e6a

📥 Commits

Reviewing files that changed from the base of the PR and between ee665de and 47dd788.

📒 Files selected for processing (2)
  • app/src/main/java/app/gamenative/gamefixes/EPIC_e345fdb9186645a48d30c3f85a8951dc.kt
  • app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
✅ Files skipped from review due to trivial changes (2)
  • app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
  • app/src/main/java/app/gamenative/gamefixes/EPIC_e345fdb9186645a48d30c3f85a8951dc.kt

📝 Walkthrough

Walkthrough

Added a new Epic-targeted game fix for Kingdom Hearts III that sets a Wine DLL override environment variable, and registered it in the GameFixesRegistry for lookup by (GameSource.EPIC, catalogId).

Changes

Cohort / File(s) Summary
New Epic Game Fix Declaration
app/src/main/java/app/gamenative/gamefixes/EPIC_e345fdb9186645a48d30c3f85a8951dc.kt
Introduced EPIC_Fix_e345fdb9186645a48d30c3f85a8951dc: KeyedGameFix as a KeyedWineEnvVarFix for Kingdom Hearts III (Epic), setting WINEDLLOVERRIDES -> mf=n;mfmediaengine=n.
Game Fixes Registry Update
app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
Added the new Epic fix entry to the fixes map so (GameSource.EPIC, "e345fdb9186645a48d30c3f85a8951dc") resolves to the fix.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • phobos665

Poem

🐇 I hop through code and fields of green,
I set a var so pixels run clean.
A tiny tweak, a DLL hush,
Kingdom hearts resume their rush.
Hooray — a rabbit's patching scene! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically identifies the primary change: adding a game fix for Kingdom Hearts III on Epic Games, which matches the core objective of the pull request.
Description check ✅ Passed The description covers the main objective, provides context with Discord link, and includes all required checklist items marked as complete; however, it notes 'Nope' for the recording requirement despite checking the box.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@unbelievableflavour unbelievableflavour force-pushed the kingdom-hearts-3-gamefix branch 2 times, most recently from 00831e2 to ee665de Compare April 12, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant