Skip to content

gamefix: Added jazz jack collection args fix#1131

Open
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:jazz-jack-collection-arg-fix
Open

gamefix: Added jazz jack collection args fix#1131
unbelievableflavour wants to merge 1 commit intoutkarshdalal:masterfrom
unbelievableflavour:jazz-jack-collection-arg-fix

Conversation

@unbelievableflavour
Copy link
Copy Markdown
Contributor

@unbelievableflavour unbelievableflavour commented Apr 7, 2026

Description

Added arg fix for jazz jack collection.

Recording

https://discord.com/channels/1378308569287622737/1488619279363477514/1491131455756173322

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Fix launch args for Jazz Jackrabbit Collection (GOG) to use the correct DOSBox configs, hide the console, and exit cleanly.

  • Bug Fixes
    • Added GOG_Fix_1808582759 via KeyedLaunchArgFix for GOG id 1808582759 with DOSBox args: -conf "..\dosbox_jazz.conf" -conf "..\dosbox_jazz_single.conf" -noconsole -c "exit".
    • Registered in GameFixesRegistry.

Written for commit ddb889c. Summary will update on new commits.

Summary by CodeRabbit

  • New Features
    • Added automatic launch configuration for GOG game 1808582759: uses optimized DOSBox settings, selects a single-player configuration, runs in silent/console-free mode, and adjusts startup commands to improve compatibility and startup behavior for that title.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f3048c5-fcac-49a9-9a6a-bfadee52c996

📥 Commits

Reviewing files that changed from the base of the PR and between fb61d49 and ddb889c.

📒 Files selected for processing (2)
  • app/src/main/java/app/gamenative/gamefixes/GOG_1808582759.kt
  • app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
✅ Files skipped from review due to trivial changes (1)
  • app/src/main/java/app/gamenative/gamefixes/GOG_1808582759.kt
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt

📝 Walkthrough

Walkthrough

Added a new public GOG game fix GOG_Fix_1808582759 that supplies DOSBox launch arguments (two config files, -noconsole, and an exit command) and registered it in GameFixesRegistry for resolution by (GameSource.GOG, catalogId).

Changes

Cohort / File(s) Summary
New GOG Game Fix Definition
app/src/main/java/app/gamenative/gamefixes/GOG_1808582759.kt
Added a public top-level KeyedGameFix (GOG_Fix_1808582759) implemented as a KeyedLaunchArgFix targeting GameSource.GOG / "1808582759", providing DOSBox launch args: dosbox_jazz.conf, dosbox_jazz_single.conf, -noconsole, and an exit command.
Registry Update
app/src/main/java/app/gamenative/gamefixes/GameFixesRegistry.kt
Inserted GOG_Fix_1808582759 into the fixes list (slightly reordered nearby GOG entries) so the registry's (GameSource, gameId) map can resolve and apply the new fix.

Sequence Diagram(s)

(omitted — changes are a small registry/launch-arg addition without new multi-component runtime flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • phobos665

Poem

🐰 I found two configs, snug and bright,

DOSBox whispers: no console tonight,
A tiny exit once setup's done,
Registry hops in—match found, one-to-one,
Off I go—game launched, and fun! 🎮🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a game fix for Jazz Jackrabbit Collection with launch arguments.
Description check ✅ Passed The description covers all required sections: change description, recording link, and completed checklist items confirming discussion and contributor agreement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@unbelievableflavour unbelievableflavour force-pushed the jazz-jack-collection-arg-fix branch from 5452b15 to 6d48048 Compare April 8, 2026 07:33
@unbelievableflavour unbelievableflavour changed the title Added jazz jack collection args fix [GameFix] Added jazz jack collection args fix Apr 8, 2026
@unbelievableflavour unbelievableflavour changed the title [GameFix] Added jazz jack collection args fix gamefix: Added jazz jack collection args fix Apr 8, 2026
@unbelievableflavour unbelievableflavour force-pushed the jazz-jack-collection-arg-fix branch from 6d48048 to fb61d49 Compare April 9, 2026 13:16
@unbelievableflavour unbelievableflavour force-pushed the jazz-jack-collection-arg-fix branch from fb61d49 to ddb889c Compare April 13, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants