feat: custom achievement sound#1123
Closed
xXJSONDeruloXx wants to merge 4 commits intoutkarshdalal:masterfrom
Closed
feat: custom achievement sound#1123xXJSONDeruloXx wants to merge 4 commits intoutkarshdalal:masterfrom
xXJSONDeruloXx wants to merge 4 commits intoutkarshdalal:masterfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP
Recording
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Adds a custom achievement unlock sound with a settings toggle and optional user-selected audio file. Plays when the achievement overlay appears, falling back to a bundled default if no custom sound is set.
PrefManager(achievementSoundEnabled,achievementSoundUri) and retains URI read permission across restarts.AchievementSoundPlayer, defaulting tores/raw/achievement_unlock.ogg.DEBUGbuilds, a test notification fires ~30s after launch.Written for commit ca61dd4. Summary will update on new commits.