Skip to content

feat: custom achievement sound#1123

Closed
xXJSONDeruloXx wants to merge 4 commits intoutkarshdalal:masterfrom
xXJSONDeruloXx:feat/custom-achievement-sound
Closed

feat: custom achievement sound#1123
xXJSONDeruloXx wants to merge 4 commits intoutkarshdalal:masterfrom
xXJSONDeruloXx:feat/custom-achievement-sound

Conversation

@xXJSONDeruloXx
Copy link
Copy Markdown
Contributor

@xXJSONDeruloXx xXJSONDeruloXx commented Apr 7, 2026

Description

WIP

Recording

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Adds a custom achievement unlock sound with a settings toggle and optional user-selected audio file. Plays when the achievement overlay appears, falling back to a bundled default if no custom sound is set.

  • New Features
    • Settings: toggle for achievement sound, plus a custom audio picker with a clear-to-default option.
    • Persists selection in PrefManager (achievementSoundEnabled, achievementSoundUri) and retains URI read permission across restarts.
    • Playback handled by AchievementSoundPlayer, defaulting to res/raw/achievement_unlock.ogg.
    • Hooked into the overlay so the sound plays on display; in DEBUG builds, a test notification fires ~30s after launch.

Written for commit ca61dd4. Summary will update on new commits.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 48c867db-4e02-405a-9015-60c00f6c84a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant