fix: replace Select/datalist with styled Combobox for workflow event selectors#320
Merged
driaug merged 2 commits intouseplunk:nextfrom Apr 1, 2026
Merged
Conversation
Member
|
This change would also need to happen on the workflow creation page. |
4 tasks
Replace the conditional Select/Input pattern with a unified Combobox (Input + Command dropdown) that always allows free-text input while offering autocomplete suggestions from previously tracked events. Applied to both workflow creation dialog and edit page (trigger event, add WAIT_FOR_EVENT step, edit WAIT_FOR_EVENT step). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6a56c8b to
3e3117e
Compare
Contributor
Author
Done! I've updated the PR to include the workflow creation page as well. I also replaced the native with a styled Combobox (using the existing cmdk Command components) so the dropdown matches the app's design system. Both the creation dialog and the edit page (trigger event, add/edit WAIT_FOR_EVENT) now use the same component. |
driaug
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the conditional Select/Input pattern with a unified Combobox (Input + Command dropdown) for event name fields in both the workflow creation dialog and edit page. Users can always type custom event names while getting autocomplete suggestions from previously tracked events.
Problem
When tracked events exist, the event name fields render as a
<Select>dropdown, preventing users from entering event names that haven't been tracked yet. This is problematic for system events likeemail.opened,email.clicked, etc. that only appear after first occurrence.Solution
Use the existing
cmdkCommand components to build a styled Combobox that:<datalist>)Changes
apps/web/src/pages/workflows/index.tsx— CreateWorkflowDialog:apps/web/src/pages/workflows/[id].tsx— Workflow edit page:Test plan
🤖 Generated with Claude Code