Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Updates the Python examples’ dependency on inferedge-moss to a newer beta version, affecting how users install and run the Python example scripts.
Changes:
- Changed
inferedge-mossin the Python examples requirements from>=1.0.0b17to==1.0.0b18.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,3 @@ | |||
| inferedge-moss>=1.0.0b17 | |||
| inferedge-moss==1.0.0b18 | |||
There was a problem hiding this comment.
Pinning inferedge-moss to an exact beta (==1.0.0b18) is inconsistent with the rest of the repo’s Python dependency specs (which use lower bounds like >=...) and can make the example environment unnecessarily brittle (e.g., prevents installing b19/patches). If the goal is just to require features from b18, prefer >=1.0.0b18 (optionally with an upper bound) instead of == unless there is a documented reason to hard-pin.
| inferedge-moss==1.0.0b18 | |
| inferedge-moss>=1.0.0b18 |
| @@ -1,3 +1,3 @@ | |||
| inferedge-moss>=1.0.0b17 | |||
| inferedge-moss==1.0.0b18 | |||
There was a problem hiding this comment.
The PR description says the inferedge-moss version was updated repo-wide, but there are still references to inferedge-moss>=1.0.0b17 elsewhere (e.g., README.md:61, examples/python/README.md:62, apps/docker/python/requirements.txt:1). If this PR is intended to standardize on b18, those should be updated too; otherwise the PR description should be narrowed to indicate it only changes the Python example requirements file.
Updated the
inferedge-mosspackage version from>=1.0.0b17to==1.0.0b18