Skip to content

Шумейко Евгений#113

Open
EvgeniiShumeiko wants to merge 2 commits intourfu-2018:masterfrom
EvgeniiShumeiko:master
Open

Шумейко Евгений#113
EvgeniiShumeiko wants to merge 2 commits intourfu-2018:masterfrom
EvgeniiShumeiko:master

Conversation

@EvgeniiShumeiko
Copy link
Copy Markdown

@EvgeniiShumeiko EvgeniiShumeiko commented Oct 18, 2018

@honest-hrundel honest-hrundel changed the title Евгений Шумейко Шумейко Евгений Oct 18, 2018
@honest-hrundel
Copy link
Copy Markdown

🍏 Пройден линтинг и базовые тесты

@honest-hrundel
Copy link
Copy Markdown

🍏 Пройден линтинг и базовые тесты

Copy link
Copy Markdown

@SemyonMakhaev SemyonMakhaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅

Привет! Молодец, что сделал 20-ое задание 👍

Comment thread tasks/1.html
div,
aside
{
background: #6594ff;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для задания цвета фона используй background-color

Comment thread tasks/10.html
<main class="global-results">
<style>
/* your styles here */
.global-scope > .title:first-letter
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс родителя точно нужно указывать? И в других местах по коду обрати внимание

Comment thread tasks/13.html
<main class="global-results">
<style>
/* your styles here */
.global-scope > div:nth-of-type(4n+1) > div:first-child
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробуй упростить селектор с помощью псевдокласса only-of-type

Comment thread tasks/14.html
<main class="global-results">
<style>
/* your styles here */
.global-scope > ul > li:before
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем такая вложенность?

Comment thread tasks/17.html

.global-scope input:checked
{
outline: none !important;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно не переназначать правило, если в верхнем селекторе сузить выборку. Можно после оператора ~ выбирать только элемент, не содержащие псевдокласс checked

Comment thread tasks/20.html
<main class="global-results">
<style>
/* your styles here */
.global-scope > .red-gt2:not(:nth-child(-n+2)) > div
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Comment thread tasks/3.html
.global-scope div > div
{
background: #6594ff;
border: none;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно не переназначать правило, если в верхнем селекторе выбрать только непосредственных потомков родительского элемента при помощи оператора >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants