chore(plg): drop unused launch entity#39
Open
Squidly271 wants to merge 1 commit into
Open
Conversation
CA's Settings menu opens in the sidebar directly — the plugin-launch indirection (`<!ENTITY launch "Apps">` + `launch="&launch;"` on the PLUGIN tag) has no remaining purpose. Removes both. No source change, no user-visible behaviour change. Originally bundled in #27; pulling out so it lands independently of the release notes flow now that #36 / #37 established CHANGES.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe plugin manifest version and MD5 checksum are updated to release values. The ChangesPlugin Manifest Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
<!ENTITY launch "Apps">declaration and the matchinglaunch="&launch;"attribute on the<PLUGIN>tag in plugins/community.applications.plg. CA's Settings menu opens directly in the sidebar now, so the launch-entity indirection has been dead for a while.Was originally bundled in #27; splitting it out as its own micro-PR so it lands without waiting on the broader release-notes work in that branch.
Why no CHANGES.md bullet
Pure .plg cleanup. No source change, no user-visible behaviour change — the plugin already behaves this way at runtime.
Test plan
pkg_build.sh+install_pkg.sh) — confirm the Apps menu still works and Settings still opens in the sidebar.🤖 Generated with Claude Code
Summary by CodeRabbit