Skip to content

chore(plg): drop unused launch entity#39

Open
Squidly271 wants to merge 1 commit into
masterfrom
chore/drop-plg-launch
Open

chore(plg): drop unused launch entity#39
Squidly271 wants to merge 1 commit into
masterfrom
chore/drop-plg-launch

Conversation

@Squidly271
Copy link
Copy Markdown
Collaborator

@Squidly271 Squidly271 commented May 18, 2026

Summary

Removes the <!ENTITY launch "Apps"> declaration and the matching launch="&launch;" attribute on the <PLUGIN> tag in plugins/community.applications.plg. CA's Settings menu opens directly in the sidebar now, so the launch-entity indirection has been dead for a while.

Was originally bundled in #27; splitting it out as its own micro-PR so it lands without waiting on the broader release-notes work in that branch.

Why no CHANGES.md bullet

Pure .plg cleanup. No source change, no user-visible behaviour change — the plugin already behaves this way at runtime.

Test plan

  • Build & install the plg on a test box (pkg_build.sh + install_pkg.sh) — confirm the Apps menu still works and Settings still opens in the sidebar.
  • No regression in plugin auto-update behaviour.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated plugin version to 2026.05.15gh with new checksums
    • Simplified plugin configuration by removing unused launch parameter

Review Change Stack

CA's Settings menu opens in the sidebar directly — the plugin-launch
indirection (`<!ENTITY launch "Apps">` + `launch="&launch;"` on the
PLUGIN tag) has no remaining purpose. Removes both. No source change,
no user-visible behaviour change.

Originally bundled in #27; pulling out so it lands independently of the
release notes flow now that #36 / #37 established CHANGES.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21ec07b1-8f55-4f11-94c4-a9326b01b703

📥 Commits

Reviewing files that changed from the base of the PR and between 2744db5 and e8c98c4.

📒 Files selected for processing (1)
  • plugins/community.applications.plg

📝 Walkthrough

Walkthrough

The plugin manifest version and MD5 checksum are updated to release values. The launch entity declaration and corresponding launch attribute on the <PLUGIN> element are removed from the plugin configuration.

Changes

Plugin Manifest Update

Layer / File(s) Summary
Version, checksum, and launch entity updates
plugins/community.applications.plg
Version entity updated to 2026.05.15gh, MD5 checksum updated to 9cb53f0f77e43e7a0d6b6109efc552b1, and the launch entity declaration removed from DOCTYPE along with its attribute from the <PLUGIN> element.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A version bump, a checksum new,

The launch has flown, the config grew,

May's update hops into the night,

Community apps polished bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title follows the conventional commits format with the 'chore' prefix and clearly describes the change: dropping the unused launch entity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-plg-launch
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/drop-plg-launch

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant