fix: Treat onboarding patch updates as completed#1884
Conversation
WalkthroughThe pull request adds test cases to verify onboarding behavior when completed versions are prior patches within the same minor version, and introduces version comparison guards in utility logic to treat matching major.minor versions as equivalent. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
+ Coverage 48.08% 48.63% +0.55%
==========================================
Files 1002 1013 +11
Lines 66502 67606 +1104
Branches 6675 6931 +256
==========================================
+ Hits 31978 32882 +904
- Misses 34403 34603 +200
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
Motivation
Description
hasOnboardingVersionDriftinonboarding-status.util.tsto ignore differences whenmajorandminorare equal so patch bumps do not count as drift.getOnboardingVersionDirectionto returnundefinedfor samemajor+minorto avoid signalingUPGRADE/DOWNGRADEon patch updates.customization.resolver.spec.tsandonboarding.mutation.spec.tsto ensure completed onboarding remainsCOMPLETEDfor same minor releases.Testing
pnpm --filter ./api exec vitest run src/unraid-api/graph/resolvers/customization/customization.resolver.spec.ts src/unraid-api/graph/resolvers/onboarding/onboarding.mutation.spec.ts, and the run succeeded withTest Files 2 passed (2)andTests 16 passed (16).pnpm --filter api lint:fixexecuted as part of the commit hooks and completed successfully.Codex Task
Summary by CodeRabbit
Bug Fixes
Tests