chore(codeowners): set Yusha + Haris as default reviewers#137
Open
djl11 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds (or updates)
.github/CODEOWNERSso that the two founding engineers — @YushaArif99 and @hmahmood24 — are the default reviewers for all paths in this repo.Either approval satisfies branch protection. GitHub's automatic author-exclusion rule means that when one of them opens a PR the other becomes the implicit required reviewer — no conditional logic, Action, or auto-assignment workflow needed.
Companion change (to be applied after this PR merges): flip
require_code_owner_reviewstotrueon themainbranch protection rule, so the code-owner requirement is enforced at merge time, not just used for auto-request.Why
Daniel's role is increasingly GTM- and sales-oriented; concentrating default code review on the two founding engineers reflects how engineering responsibility now actually distributes, and gives every PR a clear owner.
Notes
require_code_owner_reviews=trueon this repo's protection, or the branch would soft-lock (no PR could satisfy the rule because there were no code owners defined on main yet).ivyspecifically: existing per-path rules to @Sam-Armstrong are preserved as overrides — CODEOWNERS uses last-match-wins, so @Sam-Armstrong remains the owner of the Ivy framework / docs / testing paths he already owned; @YushaArif99 + @hmahmood24 become the default for everything else.