1.72 toolchain, 1.66 MSRV#3973
Merged
robertbastian merged 6 commits intounicode-org:mainfrom Aug 30, 2023
Merged
Conversation
robertbastian
requested review from
a team,
Manishearth,
echeran,
filmil,
gregtatum,
hsivonen,
nciric,
nordzilla,
sffc and
zbraniecki
as code owners
robertbastian
removed request for
echeran,
filmil,
gregtatum,
hsivonen,
nciric,
nordzilla and
zbraniecki
robertbastian
commented
Aug 30, 2023
| keys: self.keys, | ||
| values: self.values, | ||
| } | ||
| *self |
Manishearth
approved these changes
Aug 30, 2023
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
r+ for actual changes. I wasn't sure if we had decided to do this bump, AIUI our MSRV policy was to only bump when we have a reason to, yes?
|
|
||
| self.write_impl_macro(quote! { | ||
| #[clippy::msrv = "1.65"] | ||
| #[clippy::msrv = #MSRV] |
Member
Author
|
This has convenience functions on BTreeSet/map that might be ... convenient. I'm also happy to wait, but I definitely want to do 1.67 when we're allowed to, because that has |
sffc
approved these changes
Aug 30, 2023
Member
|
I'd like to use |
Member
|
that works for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reviewed commit-by-commit.