fix: guard against None values in _apply_transform#1810
Open
jnMetaCode wants to merge 1 commit intounclecode:mainfrom
Open
fix: guard against None values in _apply_transform#1810jnMetaCode wants to merge 1 commit intounclecode:mainfrom
jnMetaCode wants to merge 1 commit intounclecode:mainfrom
Conversation
…teError Signed-off-by: JiangNan <1394485448@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JsonCssExtractionStrategy._apply_transform()crashes withAttributeErrorwhenvalueisNone. This happens when a CSS or XPath selector finds no matching element — the extracted value isNone, and calling.lower(),.upper(), or.strip()on it raises:Changes
extraction_strategy.py: Added an early return guard at the start of_apply_transform:Impact
Without this fix, any extraction schema with transforms will crash on pages where optional fields are missing. This is a common scenario when scraping heterogeneous pages. The fix allows transforms to gracefully pass through
Nonevalues.