fix: pass user_query to parent class in PruningContentFilter#1809
Open
jnMetaCode wants to merge 1 commit intounclecode:mainfrom
Open
fix: pass user_query to parent class in PruningContentFilter#1809jnMetaCode wants to merge 1 commit intounclecode:mainfrom
jnMetaCode wants to merge 1 commit intounclecode:mainfrom
Conversation
Signed-off-by: JiangNan <1394485448@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PruningContentFilter.__init__()accepts auser_queryparameter but passesNoneto the parentRelevantContentFilter.__init__()instead of forwarding it:This means
self.user_queryis alwaysNoneinPruningContentFilter, even when the caller explicitly provides a query. Any downstream logic that relies onself.user_query(inherited fromRelevantContentFilter) will not work as expected.Changes
content_filter_strategy.pyline 574:super().__init__(None)→super().__init__(user_query=user_query)Impact
Users passing
user_querytoPruningContentFilterwould expect query-aware filtering, but the query was silently discarded. This fix ensures the parameter is properly forwarded to the base class.