Open
Conversation
Contributor
|
Is this PR still relevent? I'm also standardizing the way we're setting |
gzmask
commented
Feb 16, 2018
| :license {:name "The MIT License (MIT)" | ||
| :url "http://opensource.org/licenses/MIT" | ||
| :comments "Copyright (c) 2018 Unbounce Marketing Solutions Inc."} | ||
| :profiles {:dev {:dependencies [[org.clojure/test.check "0.9.0"]]}} |
Contributor
Author
There was a problem hiding this comment.
this is still relevant as generative testing rely on this dependency.
gzmask
commented
Feb 16, 2018
| (s/def ::metric string?) | ||
| (s/def ::tags (s/coll-of string? :kind vector?)) | ||
| (s/def ::opts (s/keys :req-un [::tags ::sample-rate])) | ||
| (s/def ::opts* (s/keys* :req-un [::tags ::sample-rate])) |
Contributor
Author
There was a problem hiding this comment.
this is also nice to have for (f :key 'value') compare to (f {:key 'value}) .
But agrees that we should only be using one and not both styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.