Skip to content

fix: sort select background in dark mode#1427

Closed
fish-404 wants to merge 1 commit intoumputun:masterfrom
fish-404:master
Closed

fix: sort select background in dark mode#1427
fish-404 wants to merge 1 commit intoumputun:masterfrom
fish-404:master

Conversation

@fish-404
Copy link
Copy Markdown

@fish-404 fish-404 commented Jul 22, 2022

Fix sort select background in dark mode in order to see the text clearly.

image

@fish-404 fish-404 requested a review from umputun as a code owner July 22, 2022 01:20
@umputun umputun requested a review from akellbl4 July 22, 2022 01:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #1427 (1e90990) into master (5db6e43) will not change coverage.
The diff coverage is n/a.

❗ Current head 1e90990 differs from pull request most recent head 53b424a. Consider uploading reports for the commit 53b424a to get more accurate results

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      743      743           
=======================================
  Hits         1691     1691           
  Misses       1087     1087           
  Partials      131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db6e43...53b424a. Read the comment docs.

@akellbl4
Copy link
Copy Markdown
Collaborator

akellbl4 commented Jul 22, 2022

@fish-404 hey, thanks for contribution. I'm curious what browser renders select dropdown like so?

@fish-404
Copy link
Copy Markdown
Author

fish-404 commented Jul 22, 2022

@fish-404 hey, thanks for contribution. I'm curious what browser renders select dropdown like so?

@akellbl4 Hey, I use Firefox 100.0.2, inspect the default background-color is rgb(233, 233, 237).

Take Edge and Chrome to test, their default background-color is rgb(255, 255, 255) which can see the text clearly.

@akellbl4
Copy link
Copy Markdown
Collaborator

akellbl4 commented Jul 22, 2022 •
edited
Loading

Is it on Windows?
Also, do you have color-scheme property in css on your site?

@akellbl4
Copy link
Copy Markdown
Collaborator

akellbl4 commented Jul 22, 2022

I've checked the problem. It should be fixed in slightly different way. The problem is in color-scheme. We have an issue connected with it #1430
Can you help with it?

@fish-404
Copy link
Copy Markdown
Author

fish-404 commented Jul 24, 2022

I've checked the problem. It should be fixed in slightly different way. The problem is in color-scheme. We have an issue connected with it #1430 Can you help with it?

OK, but I'm not sure if I am able to help, will check it later.

@arfedulov
Copy link
Copy Markdown

arfedulov commented Mar 9, 2026

This pull request looks like a useful fix and probably won't hurt to merge before the general solution for #1430 is implemented

@amdevz amdevz mentioned this pull request Mar 21, 2026
Merged
@paskal
Copy link
Copy Markdown
Collaborator

paskal commented Apr 14, 2026

thanks for the original report and patch — this one sat too long. closing in favour of #2023, which just merged and fixes the underlying color-scheme problem at the source: the iframe now sets color-scheme: dark / light on the inner <html> to match the active theme, so Firefox uses the proper dark user-agent chrome for native form controls (including the native <select> dropdown popup).

the one-line change here would layer on top of that by forcing background-color on the (invisible, opacity: 0) <select> element, which on some Firefox versions can actually suppress the color-scheme-driven native dropdown theming — so merging it now could partially undo #2023.

if you still see a problem with the sort select in dark Firefox after #2023, please reopen or file a fresh issue with a screenshot against current master — happy to take another look.

@paskal paskal closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umputun umputun Awaiting requested review from umputun umputun is a code owner

@akellbl4 akellbl4 Awaiting requested review from akellbl4

Assignees

No one assigned

Labels

frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fish-404 @akellbl4 @arfedulov @paskal