Skip to content

Feat: Add recordUrl field for pageAction editor#311

Draft
Copilot wants to merge 2 commits intofeat/pageAction-in-currentTabfrom
copilot/sub-pr-286-again
Draft

Feat: Add recordUrl field for pageAction editor#311
Copilot wants to merge 2 commits intofeat/pageAction-in-currentTabfrom
copilot/sub-pr-286-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

startUrl was serving dual purposes: execution target and recorder launch URL. This conflates two distinct concerns — e.g. startUrl may be a wildcard pattern for matchesPageActionUrl, making it unsuitable as a concrete recorder navigation URL.

Changes

  • New recordUrl?: string field on PageActionOption — used exclusively when launching the recorder; ignored at execution time
  • Editor UIrecordUrl input added below startUrl in PageActionSection; REC button enables when either URL is set
  • Recorder launch (CommandEditDialog) — uses recordUrl || startUrl as the navigation target when opening the recorder window; stores recordUrl in PA_RECORDING session data
  • Reset handler (background.ts) — reloads recording tab to recordUrl || startUrl on reset
  • Type + schemarecordUrl added to PageActionOption type and Zod schema (optional)
  • i18n — translations added for all 14 locales
export type PageActionOption = {
  startUrl: string    // used for execution + matchesPageActionUrl
  recordUrl?: string  // used only when opening the recorder
  openMode: PAGE_ACTION_OPEN_MODE
  steps: Array<PageActionStep>
  userVariables?: Array<UserVariable>
}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix redundant checks in page action for current tab Feat: Add recordUrl field for pageAction editor Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants