Skip to content

fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除#310

Merged
ujiro99 merged 2 commits intofeat/pageAction-in-currentTabfrom
copilot/sub-pr-286
Mar 3, 2026
Merged

fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除#310
ujiro99 merged 2 commits intofeat/pageAction-in-currentTabfrom
copilot/sub-pr-286

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

pageAction.tsuseSecondary ブランチで、CURRENT_TAB の判定が両方とも PAGE_ACTION_OPEN_MODE.TAB を返すデッドコードになっていた。

変更内容

  • useSecondary 時の openMode 解決ロジックを簡略化
    • TAB → WINDOWWINDOW → TAB、それ以外(CURRENT_TAB 含む)→ TAB という意図は変わらず、冗長な三項演算子を削除
// Before
: command.pageActionOption.openMode === PAGE_ACTION_OPEN_MODE.CURRENT_TAB
  ? PAGE_ACTION_OPEN_MODE.TAB // Open in new tab when secondary is pressed
  : PAGE_ACTION_OPEN_MODE.TAB // ← 同じ値

// After
: PAGE_ACTION_OPEN_MODE.TAB // Open in new tab when secondary is pressed

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix redundant CURRENT_TAB check in page action code fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除 Mar 3, 2026
@ujiro99 ujiro99 marked this pull request as ready for review March 3, 2026 23:01
@ujiro99 ujiro99 merged commit 73edfa1 into feat/pageAction-in-currentTab Mar 3, 2026
1 check passed
@ujiro99 ujiro99 deleted the copilot/sub-pr-286 branch March 3, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants