fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除#310
Merged
ujiro99 merged 2 commits intofeat/pageAction-in-currentTabfrom Mar 3, 2026
Merged
fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除#310ujiro99 merged 2 commits intofeat/pageAction-in-currentTabfrom
ujiro99 merged 2 commits intofeat/pageAction-in-currentTabfrom
Conversation
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix redundant CURRENT_TAB check in page action code
fix: useSecondary の CURRENT_TAB 条件分岐の冗長コードを削除
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pageAction.tsのuseSecondaryブランチで、CURRENT_TABの判定が両方ともPAGE_ACTION_OPEN_MODE.TABを返すデッドコードになっていた。変更内容
useSecondary時のopenMode解決ロジックを簡略化TAB → WINDOW、WINDOW → TAB、それ以外(CURRENT_TAB含む)→TABという意図は変わらず、冗長な三項演算子を削除💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.