Skip to content

fix: dropping eas component in IM calculation#94

Open
lispandfound wants to merge 1 commit intopegasusfrom
fix_drop_eas
Open

fix: dropping eas component in IM calculation#94
lispandfound wants to merge 1 commit intopegasusfrom
fix_drop_eas

Conversation

@lispandfound
Copy link
Copy Markdown
Contributor

We are currently dropping the EAS component of im calculation, this small PR fixes that by adding eas to the initial dataset calculation

Copilot AI review requested due to automatic review settings March 2, 2026 22:14
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Intensity Measure (IM) calculation process. Previously, the 'eas' component was being dropped, leading to incomplete or inaccurate results. By integrating 'eas' into the initial dataset calculation, this change ensures that all necessary components are considered, thereby improving the accuracy and completeness of the IM outputs.

Highlights

  • IM Calculation Fix: Resolved an issue where the 'eas' component was inadvertently excluded from Intensity Measure (IM) calculations, ensuring its proper inclusion in the initial dataset.
Changelog
  • workflow/scripts/im_calc.py
    • Included 'eas' in the list of components for IM calculation dataset initialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the eas component to the intensity measure calculation, fixing an issue where it was being dropped. I have one suggestion to improve the code's maintainability by logically ordering the components list.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes intensity measure output formatting by ensuring the EAS component is included in the initial xarray.Dataset component coordinate, preventing EAS values from being dropped during dataset assignment/alignment.

Changes:

  • Add "eas" to the component coordinate list when creating the IM output dataset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@joelridden joelridden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe look into the test as to why the hf input code is failing though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants