fix: dropping eas component in IM calculation#94
fix: dropping eas component in IM calculation#94lispandfound wants to merge 1 commit intopegasusfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Intensity Measure (IM) calculation process. Previously, the 'eas' component was being dropped, leading to incomplete or inaccurate results. By integrating 'eas' into the initial dataset calculation, this change ensures that all necessary components are considered, thereby improving the accuracy and completeness of the IM outputs. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the eas component to the intensity measure calculation, fixing an issue where it was being dropped. I have one suggestion to improve the code's maintainability by logically ordering the components list.
There was a problem hiding this comment.
Pull request overview
This PR fixes intensity measure output formatting by ensuring the EAS component is included in the initial xarray.Dataset component coordinate, preventing EAS values from being dropped during dataset assignment/alignment.
Changes:
- Add
"eas"to thecomponentcoordinate list when creating the IM output dataset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joelridden
left a comment
There was a problem hiding this comment.
Maybe look into the test as to why the hf input code is failing though
We are currently dropping the EAS component of im calculation, this small PR fixes that by adding eas to the initial dataset calculation