Merged
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
AndrewRidden-Harper
approved these changes
Jun 26, 2024
Contributor
AndrewRidden-Harper
left a comment
AndrewRidden-Harper
left a comment
There was a problem hiding this comment.
Nice work! I didn't explicitly check any maths but didn't see any obvious problems when I glanced over it. Let me know if a more detailed check of the maths would be useful
lispandfound
commented
Jun 26, 2024
| source_b_global_coordinates = ( | ||
| source_b.fault_coordinates_to_wgs_depth_coordinates(fault_coordinates[2:]) | ||
| ) | ||
| return coordinates.distance_between_wgs_depth_coordinates( |
Contributor
Author
There was a problem hiding this comment.
This is a function that either needs to be in qcore or I can copy it into this repo. I think a distance function between coordinates (like ll_dist but vectorised, more accurate, etc) is probably welcome in qcore?
Contributor
There was a problem hiding this comment.
I agree this could be welcomed into qcore if it's going to be used in multiple repos
sungeunbae
reviewed
Jun 27, 2024
wiki/Sources.md
Outdated
| 2. **Plane Geometry**: This a 2-dimensional source geometry consisting of a single plane. The extents of the geometry are its corners. The `qcore.sources` module uses the `Plane` class to model single plane geometry. | ||
| 3. **Multi-Planar Geometry**: This is a 2-dimensional source geometry consisting of a number of connected planes. The extents of the geometry are the corners of the end fault planes. The `qcore.sources` module uses the `Fault` class to model multi-planar geometry. | ||
|
|
||
| Type-I fault are an instance of the the first geometry, type-2 faults |
Member
There was a problem hiding this comment.
Type-1 (sorry, nitpicking!!)
joelridden
approved these changes
Jun 30, 2024
AndrewRidden-Harper
approved these changes
Jul 2, 2024
joelridden
reviewed
Jul 3, 2024
AndrewRidden-Harper
approved these changes
Jul 3, 2024
Contributor
AndrewRidden-Harper
left a comment
AndrewRidden-Harper
left a comment
There was a problem hiding this comment.
nice updates
sungeunbae
approved these changes
Jul 5, 2024
joelridden
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the inaugural sources module to source_modelling repo.