Canterbury and Wellington are always Type 4 and 3 by default

[sungeunbae]

Aaron consulted Robin Lee and confirmed all historical Canterbury and Wellington basins are of type 4 and 3 respectively.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the type attribute for specific Canterbury and Wellington basin entries within the nzcvm_registry.yaml file. This ensures that these historical basin models consistently reflect their confirmed classifications, improving data accuracy and consistency across the registry.

Highlights

• Canterbury Basin Types: Standardized all Canterbury basin entries (Canterbury_v18p1, Canterbury_v18p2, Canterbury_v18p3) to type: 4 based on confirmed historical data.
• Wellington Basin Types: Standardized all Wellington basin entries (Wellington_v19p1, Wellington_v19p6) to type: 3 based on confirmed historical data.

Changelog

• nzcvm_registry.yaml
  • Added type: 4 to the Canterbury_v18p1 basin definition.
  • Added type: 4 to the Canterbury_v18p2 basin definition.
  • Added type: 4 to the Canterbury_v18p3 basin definition.
  • Added type: 3 to the Wellington_v19p1 basin definition.
  • Added type: 3 to the Wellington_v19p6 basin definition.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the nzcvm_registry.yaml file to add a type attribute to several historical Canterbury and Wellington basin models. The changes set type: 4 for Canterbury_v18p1, Canterbury_v18p2, and Canterbury_v18p3, and type: 3 for Wellington_v19p1 and Wellington_v19p6. These changes align with the types of more recent versions of these basins and are consistent with the PR's goal. The changes are valid according to the project's schema.

[Copilot]

Pull request overview

This PR updates the NZCVM dataset registry to add missing basin type metadata for several existing basin versions, improving consistency with the registry schema and downstream tooling that surfaces basin type information (e.g., wiki generation).

Changes:

• Added type: 4 to Canterbury basin versions Canterbury_v18p1, Canterbury_v18p2, and Canterbury_v18p3.
• Added type: 3 to Wellington basin versions Wellington_v19p1 and Wellington_v19p6.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Ayushi-EQ]

Canterbury - Type 4 (since the start)
Wellington - Type 3 (since the start)
Everything else was Type 1 historically, except in NZVM2p09, Southland and Kaikoura became Type 2, and Nelson became Type 3.

[AaronJR474]

This is the exact comment:

"Canterbury has always been Type 4 as long as we've run production quality simulations back in 2016/2017 with only minor changes within those 2 years.

Wellington has changed from one model to another. The suffix indicates the year and month. e.g. 19p1 is January of 2019.

v19p1 and/or v19p6 is Semmens (2010) or something similar.
v21p8 is probably Hill (2022) interim model.
v25p5 is Hill (2022) city-scale model stitched together with his preferred regional-scale model. Basically the best model coming out of that study."

I suggest that the remainder of the basins, which do not have a type specified, be corrected. I believe this really only happens for Wellington and Canterbury where some of the past basins do not have a type specified. This came about as I was preparing the basin identifications for NZCVM v2.06 which was used in CyberShakeNZ 200m and 100m. Whichever Canterbury and Wellington basin versions were used by this NZCVM version had nans.