Adjust EAS smoothing

[joelridden]

Based on a discussion about FAS smoothing for EAS we should apply the konno smoothing after the EAS component calculation. Sadly this will slow down the calculation due to having to apply smoothing twice in the function, but I see no way around it :(
https://uceqeng.slack.com/archives/C0C0QPGDR/p1773555712228999?thread_ts=1773553959.094039&cid=C0C0QPGDR

The differences from what I have seen is not much but it's meant to the the proper way for EAS.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Equivalent Acceleration Spectrum (EAS) calculation within the fourier_amplitude_spectra function. The primary goal is to ensure that Konno smoothing is applied correctly to the EAS values themselves, rather than deriving EAS from already smoothed Fourier Amplitude Spectra (FAS) components. This change aligns the calculation with proper engineering practices, although it may introduce a slight increase in computational time due to the additional smoothing step.

Highlights

• EAS Smoothing Logic: Modified the fourier_amplitude_spectra function to apply Konno smoothing to the Equivalent Acceleration Spectrum (EAS) after its calculation from unsmoothed Fourier Amplitude Spectra (FAS) components. This corrects the methodology, ensuring smoothing is applied directly to the EAS values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adjusts the calculation of the Effective Amplitude Spectrum (EAS) to apply Konno-Ohmachi smoothing after the EAS component calculation, which is the correct approach. The change is logical and well-explained. My review includes one suggestion to address code duplication introduced by this change, which would improve the maintainability of the code.