Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 17554658438Details
💛 - Coveralls |
nss10
added a commit
that referenced
this pull request
Aug 15, 2025
Contributor
Author
|
Waiting for -- uc-cdis/cdis-python-utils#72 to be reviewed and merged |
markxiao
approved these changes
Sep 8, 2025
markxiao
left a comment
markxiao
left a comment
There was a problem hiding this comment.
code look good. I did not test myself b/c my env is not up yet.
| if app.metrics.enabled: | ||
| app.mount("/metrics", app.metrics.get_asgi_app()) | ||
|
|
||
| app.include_router(s3_root_router, tags=["S3"]) |
Collaborator
There was a problem hiding this comment.
@nss10 When you have a chance could you add a comment explaining why it's not done at the same time as the other routers 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: MIDRC-1098
This PR fixes an issue where requests to the /metrics endpoint were incorrectly falling back to s3_root_router.
NOTE: This PR depends on -- uc-cdis/cdis-python-utils#72
Bug Fixes
/metricsendpoint will be correctly routed to prometheus app, previously it was accidentally being routed tos3_root_router