Skip to content

fix(bucketregex): match explicitly before trying regex matching for buckets PD-145#1341

Merged
Avantol13 merged 1 commit intomasterfrom
fix/bucketregex
Apr 6, 2026
Merged

fix(bucketregex): match explicitly before trying regex matching for buckets PD-145#1341
Avantol13 merged 1 commit intomasterfrom
fix/bucketregex

Conversation

@Avantol13
Copy link
Copy Markdown
Contributor

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

  • Return explicitly matching bucket name over regex-matched if available (ensures order of configured S3_BUCKETS doesn't change expected behavior)

Improvements

Dependency updates

Deployment changes

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23952530727

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 75.073%

Files with Coverage Reduction New Missed Lines %
blueprints/data/indexd.py 27 94.59%
Totals Coverage Status
Change from base Build 23756457076: 0.006%
Covered Lines: 8460
Relevant Lines: 11269

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Test summary after running integration tests

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 15
tests/test_centralized_auth.py 15 1 0 16
tests/test_audit_service.py 3 0 3 6
tests/test_data_upload.py 8 0 1 9
tests/test_presigned_url.py 7 0 0 7
tests/test_dbgap.py 4 0 1 5
tests/test_user_token.py 5 0 0 5
tests/test_drs_endpoint.py 4 0 0 4
tests/test_register_user.py 1 1 0 2
tests/test_oidc_client.py 2 0 0 2
tests/test_google_data_access.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_ras_authn.py 0 0 3 3
TOTAL 66 2 8 76

Test summary after rerunning failed integration tests

filepath passed SUBTOTAL
tests/test_register_user.py 1 1
tests/test_centralized_auth.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

@Avantol13 Avantol13 merged commit 8e64bd0 into master Apr 6, 2026
16 checks passed
@Avantol13 Avantol13 deleted the fix/bucketregex branch April 6, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants