Skip to content

Catch 404 when deleting user in arborist#1340

Closed
k-burt-uch wants to merge 1 commit intomasterfrom
fix/usersync-fail-on-missing-user
Closed

Catch 404 when deleting user in arborist#1340
k-burt-uch wants to merge 1 commit intomasterfrom
fix/usersync-fail-on-missing-user

Conversation

@k-burt-uch
Copy link
Copy Markdown
Contributor

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

  • Usersync no longer fails when deleting a user that does not exist in arborist.

Improvements

Dependency updates

Deployment changes

@k-burt-uch
Copy link
Copy Markdown
Contributor Author

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23924966144

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 75.055%

Files with Coverage Reduction New Missed Lines %
sync/sync_users.py 49 81.9%
Totals Coverage Status
Change from base Build 23756457076: -0.01%
Covered Lines: 8458
Relevant Lines: 11269

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only ignore 404s, and raise any other type of error 😬

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

filepath passed skipped SUBTOTAL
tests/test_oauth2.py 15 0 15
tests/test_centralized_auth.py 16 0 16
tests/test_audit_service.py 3 3 6
tests/test_data_upload.py 8 1 9
tests/test_presigned_url.py 7 0 7
tests/test_dbgap.py 4 1 5
tests/test_drs_endpoint.py 4 0 4
tests/test_register_user.py 2 0 2
tests/test_user_token.py 5 0 5
tests/test_google_data_access.py 1 0 1
tests/test_client_credentials.py 1 0 1
tests/test_oidc_client.py 2 0 2
tests/test_ras_authn.py 0 3 3
TOTAL 68 8 76

Please find the detailed integration test report here

Please find the Github Action logs here

@k-burt-uch k-burt-uch closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants