add value to Boolean input type and change triggerProxyEmail from boo…#297
Merged
danielolaviobr merged 2 commits intomasterfrom Dec 1, 2025
Conversation
alexcupit
approved these changes
Nov 20, 2025
alexcupit
left a comment
alexcupit
left a comment
There was a problem hiding this comment.
Looks good, just one minor comment!
| "type": "boolean", | ||
| "TriggerProxyEmail": { | ||
| "type": "string", | ||
| "description": "", |
There was a problem hiding this comment.
is it worth adding in a description of what the email should be? The proxy email that's been created and used for the account creation?
Contributor
Author
There was a problem hiding this comment.
we could add, yes, just to be clear, we want to send an email, the proxy email specifically, right?
There was a problem hiding this comment.
yes, it would be the proxy email that's returned from the getAccountEmail action I believe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lean to string