Skip to content

Tidy up MegaCli options #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mskuta wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tidy up MegaCli options #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9865b9a
Add missing hyphen to MegaCli option
Mar 9, 2019
a0a804a
Do not let MegaCli write a log file
Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymegacli/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __init__(self, megacli_path, log=None):

def run_command(self, *args):
exit_re = re.compile('^Exit Code: (.*)$')
cmd = [self.megacli_path] + list(args)
cmd = [self.megacli_path] + list(args) + ['-NoLog']
if self.log:
self.log.debug('executing: ' + ' '.join(map(pipes.quote, cmd)))
p = subprocess.Popen(
Expand Down Expand Up @@ -276,7 +276,7 @@ def patrol_read_status(self):
@property
def PDs(self):
return Disk.from_output(self.parent.run_command(
'-PDList', 'a%d' % self.controller_number
'-PDList', '-a%d' % self.controller_number
), self)

@property
Expand Down