Skip to content
This repository was archived by the owner on Dec 3, 2019. It is now read-only.

Revert "Allow setting token via createCanduit options"#16

Open
tesoy-xx wants to merge 1 commit into
uber-archive:masterfrom
tesoy-xx:revert-6-patch-1
Open

Revert "Allow setting token via createCanduit options"#16
tesoy-xx wants to merge 1 commit into
uber-archive:masterfrom
tesoy-xx:revert-6-patch-1

Conversation

@tesoy-xx
Copy link
Copy Markdown

Reverts #6

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@timhirsh
Copy link
Copy Markdown
Contributor

@tesoy-xx, can you provide a description of the problem and list the steps you took to test this change, please? This creates a backwards incompatibility for use cases that include a conduit token during instantiation.

@tesoy-xx tesoy-xx mentioned this pull request Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants