feat(adapter): add support for cross-field ORs#261
Open
jp06 wants to merge 1 commit intotypesense:masterfrom
Open
feat(adapter): add support for cross-field ORs#261jp06 wants to merge 1 commit intotypesense:masterfrom
jp06 wants to merge 1 commit intotypesense:masterfrom
Conversation
Author
|
I noticed this open PR: #260 |
Collaborator
|
That PR handles JOINs specifically, but also handles facet filters alongside those. I like this approach more for a starting point myself, could you also add some tests under the testground folder? |
Author
|
@tharropoulos Thanks. I actually am thinking of another approach to my problem as I've learned some things, but I can continue this at some points to add some tests on my free time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for cross-field ORs by grouping different fields with parentheses
()and joining them with||. Before it will just warn that this is not supported.I had to implement this for a use case of using separate fields together for a hierarchical multi-level select.
I'm thinking it was a limitation on when this was first written which is why this hasn't implemented yet. Let me know if there are still existing limitations on this that I'm not aware of. Feel free to close if you think this will break stuff.
PR Checklist