Update Scala Native to 0.5 and bump other library versions#669
Merged
cquiroz merged 1 commit intotypelevel:masterfrom Mar 17, 2026
Merged
Update Scala Native to 0.5 and bump other library versions#669cquiroz merged 1 commit intotypelevel:masterfrom
cquiroz merged 1 commit intotypelevel:masterfrom
Conversation
hugo-vrijswijk
force-pushed
the
scala-native-0-5
branch
from
939a123 to
0a02649
Compare
cquiroz
reviewed
Mar 17, 2026
|
|
||
| object Versions { | ||
| val Scala3 = "3.1.1" | ||
| val Scala3 = "3.3.7" |
cquiroz
reviewed
Mar 17, 2026
| override def plus(that: Money): Money = that.currency match { | ||
| case this.currency ⇒ new Money(this.amount + that.amount)(currency) | ||
| case _ ⇒ throw new UnsupportedOperationException("plus not supported for cross-currency comparison - use moneyPlus") | ||
| case this.currency => new Money(this.amount + that.amount)(currency) |
Collaborator
There was a problem hiding this comment.
I didn't recall we had that character in the codebase, thanks ascii is better
Contributor
Author
There was a problem hiding this comment.
Yeah Scala 3.3 didn't like it :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.