More constness/C23 fixes [0.4.x]#167
Closed
hhoffstaette wants to merge 4 commits intotwaugh:masterfrom
Closed
Conversation
Version 0.4.4 introduced support for Git diffs without content hunks (renames, copies, mode-only changes, binary files), which changed file numbering behavior and broke compatibility with 0.4.3. This caused scripts using -N/-F options to fail. Add --git-extended-diffs=exclude|include option to control this behavior. In 0.4.x, the default is 'exclude' to restore 0.4.3 compatibility. Users wanting the 0.4.4 behavior can use 'include'. Implementation: - Add git_extended_diffs_mode enum with EXCLUDE/INCLUDE values - Skip extended diffs when in exclude mode to restore 0.4.3 behavior - Add comprehensive test coverage in git-extended-diffs-exclude/ - Update all existing git-* tests to use --git-extended-diffs=include - Update documentation for filterdiff, lsdiff, grepdiff, patchview - Update NEWS to explain the reversion and new option The default will change to 'include' in version 0.5.0 for modern Git workflow support. Addresses GitHub issue twaugh#157. Assisted-by: Claude Code
Extends git-extended-diffs-exclude test to cover three previously uncovered code paths: GIT_DIFF_NORMAL handling in exclude mode, goto eof path for extended diffs at end of file, and invalid argument error handling. Assisted-by: Claude Code
Add --git-extended-diffs option to restore 0.4.3 compatibility
This is a followup to twaugh#159 and fixes more glibc-2.43/C23 related const warnings. Where we can, we make things more const; where necessary we explicitly treat mutable things as mutable instead of pretending that they are not. Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
4 tasks
Contributor
Author
|
Aaargh..wrong target branch 🙈 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
===========================================
- Coverage 83.60% 65.15% -18.45%
===========================================
Files 5 7 +2
Lines 4196 6015 +1819
Branches 1001 1507 +506
===========================================
+ Hits 3508 3919 +411
- Misses 688 2096 +1408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup const/C23 fixes for #159
Type of Change
Testing
make check: