Conversation
Change the help text filtering syntax from (parentheses) to {braces}
to allow free use of parentheses and square brackets in help output.
Previously, options ending with (toolname) were filtered to only show
in specific tools (filterdiff, lsdiff, grepdiff), but this prevented
using parentheses for natural purposes like "(default: keep)" or
"(original-before or original-after)". Square brackets like "[OPTION]"
are also common in CLI help text.
Changes to src/filterdiff.c:
- Parser now looks for {toolname} instead of (toolname) at line ends
- All help text annotations changed from [toolname] to {toolname}
- Filters applied to every line of multi-line options to prevent
orphaned descriptions from appearing in wrong tools
Changes to doc/patchutils.xml:
- Added missing lsdiff options: --addoldprefix, --addnewprefix,
-I/--include-from-file, -X/--exclude-from-file
- Added missing grepdiff option: --empty-files-as-absent
- Documented all options in both synopsis and description sections
This ensures help output matches actual available options and allows
natural use of punctuation in help text.
Assisted-by: Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.4.x #163 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 5 5
Lines 4173 4173
Branches 997 997
=======================================
Hits 3489 3489
Misses 684 684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation fixes for man pages and
--helpoutput.