Skip to content

Require @redis/client ^5.0.0 for RedisKvStore#819

Merged
Murderlon merged 4 commits intomainfrom
dependabot/npm_and_yarn/redis/client-5.11.0
Apr 7, 2026
Merged

Require @redis/client ^5.0.0 for RedisKvStore#819
Murderlon merged 4 commits intomainfrom
dependabot/npm_and_yarn/redis/client-5.11.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2026

  • Investigate CI failures from bumping @redis/client 1.6.0 → 5.11.0
  • Identify TypeScript errors in packages/utils/src/kvstores/RedisKvStore.ts (cursor type changed from number to string | Buffer in v5)
  • Fix list() method to use scanIterator (idiomatic v5 API) instead of manual cursor loop
  • Verify build passes (no TypeScript errors)
  • Verify utils tests pass
  • Change required version to ^5.0.0 in package.json files, update lock file, and update changeset description

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 1, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 4b033d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@tus/file-store Minor
@tus/server Minor
@tus/utils Minor
@tus/azure-store Patch
@tus/gcs-store Patch
@tus/s3-store Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 1, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​redis/​client@​1.6.0 ⏵ 5.11.0100 +110078 +290100

View full report

Bumps [@redis/client](https://github.com/redis/node-redis) from 1.6.0 to 5.11.0.
- [Release notes](https://github.com/redis/node-redis/releases)
- [Changelog](https://github.com/redis/node-redis/blob/master/CHANGELOG.md)
- [Commits](https://github.com/redis/node-redis/compare/client@1.6.0...json@5.11.0)

---
updated-dependencies:
- dependency-name: "@redis/client"
  dependency-version: 5.11.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/redis/client-5.11.0 branch from 101c6a5 to 0ee40db Compare April 7, 2026 12:33
@Murderlon
Copy link
Copy Markdown
Collaborator

@copilot we're Bump @redis/client from 1.6.0 to 5.11.0, a lot of major versions, and now the build is failing. Make the necessary changes to make it work again. CI will reveal if all tests work as expected, but try to confirm the basics yourself.

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

@copilot we're Bump @redis/client from 1.6.0 to 5.11.0, a lot of major versions, and now the build is failing. Make the necessary changes to make it work again. CI will reveal if all tests work as exp...

Fixed in fc8c135. The @redis/client v5 changed the scan cursor type from number to string | Buffer (RedisArgument), which caused the TypeScript build errors. Updated RedisKvStore.list() to use the idiomatic scanIterator method (which handles cursor management internally as strings), replacing the manual cursor loop. Build now passes cleanly.

Copilot AI requested a review from Murderlon April 7, 2026 12:40
@Murderlon
Copy link
Copy Markdown
Collaborator

@copilot change the required version to ^5.0.0 instead of 5.11.0. Make sure to update the lock file and the new changeset description as well

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

@copilot change the required version to ^5.0.0 instead of 5.11.0. Make sure to update the lock file and the new changeset description as well

Done in 4b033d1. Updated the version to ^5.0.0 in both packages/file-store/package.json and packages/server/package.json, regenerated the lock file, and updated the changeset description accordingly.

@Murderlon Murderlon changed the title Bump @redis/client from 1.6.0 to 5.11.0 Require @redis/client ^5.0.0 for RedisKvStore Apr 7, 2026
@Murderlon Murderlon merged commit 43152b5 into main Apr 7, 2026
5 checks passed
@Murderlon Murderlon deleted the dependabot/npm_and_yarn/redis/client-5.11.0 branch April 7, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants