Merged
Conversation
There was a problem hiding this comment.
Pull request overview
WindowThumbWall の通知/フラッシュ由来の注意表示ロジックを整理しつつ、現在アクティブな監視元ウィンドウを白枠で常時識別できるようにし、あわせて 0.6.6 へ版数同期とドキュメント更新を行う PR です。
Changes:
- 監視元のフォアグラウンド(アクティブ)ウィンドウに、点滅しない白枠(赤/オレンジ優先)を追加
- 通知が同一アプリ内で曖昧一致になった場合、同一アプリでタスクバーフラッシュ(赤)が既にあるときはオレンジ表示を抑制
- 通知マッチングを「監視スロットのみ」「新規追加トーストのみ」に寄せ、関連ドキュメントとバージョンを 0.6.6 に更新
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WindowThumbWall.Tests/NotificationWindowMatcherTests.cs | 通知→ウィンドウ解決の新方針(アプリ同定必須・監視内のみ)に合わせてテストを刷新 |
| WindowThumbWall.Tests/NotificationAttentionPolicyTests.cs | オレンジ抑制ポリシー(同一アプリにフラッシュがある場合)を新規テスト追加 |
| WindowThumbWall.csproj | アプリ版数を 0.6.6 に更新 |
| README.md | 赤/オレンジ注意枠と白のアクティブ枠を追記 |
| README.ja.md | 日本語 README に白枠・説明を追記(開発者ガイドへの誘導も追加) |
| packaging/Package.appxmanifest | MSIX の Identity Version を 0.6.6.0 に更新 |
| packaging/AppxManifest.xml | MSIX の Identity Version を 0.6.6.0 に更新 |
| NotificationWindowMatcher.cs | 通知マッチングを「アプリ同定必須」「同一アプリ内での絞り込み」に寄せ、内部 API をテスト可能に調整 |
| NotificationAttentionPolicy.cs | 曖昧通知(オレンジ)をフラッシュ状況で抑制する判定を新規追加 |
| MainWindow.xaml.cs | アクティブ枠(白・非点滅)描画とアクティブ元ウィンドウ追跡を追加 |
| MainWindow.Notifications.cs | 既存通知のリプレイ抑止、新規通知のみグループ化、候補を監視スロットに限定、オレンジ抑制を組み込み |
| docs/notification-attention-design.md | 新しい注意表示ルール(新規通知のみ、監視内のみ、白枠、オレンジ抑制)を設計書に反映 |
| docs/developer-guide.md | Codex の “Run” ダイアログ向け起動コマンド例を追記 |
| AGENTS.md | ローカルエージェント運用のガードレールをドキュメント化 |
| .github/copilot-instructions.local.md | ローカル Copilot 指示(範囲制御・配布形式前提など)を追加 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Impact
Validation
dotnet build WindowThumbWall.csproj -c Releasedotnet test WindowThumbWall.Tests\WindowThumbWall.Tests.csproj -c Releasepowershell -ExecutionPolicy Bypass -File .\packaging\build-all.ps1 -Configuration Release -Runtime win-x64