Conversation
| To test out changes to the *code*, you can change to the `python/` subdirectory, | ||
| and run `make` to compile the C code. | ||
| If you then execute `python` from this subdirectory (and only this one!), | ||
| If you then execute python commands from this subdirectory (and only this one!), |
There was a problem hiding this comment.
you can't run python; you can only run uv run python etc
| To install the hook: | ||
|
|
||
| ```bash | ||
| $ uv run prek install |
There was a problem hiding this comment.
this was already said above
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 37 37
Lines 32153 32153
Branches 5143 5143
=======================================
Hits 29556 29556
Misses 2264 2264
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| Note that this guide covers the most complex case of adding a new function to both | ||
| the C and Python APIs. | ||
|
|
||
| 0. Draft a docstring for your function, that describes exactly what the function |
There was a problem hiding this comment.
since I'm not building locally I haven't checked if we can actually start a list at zero. but I think this should be first, not last?
|
Hmm - what version of doxygen are you using? I've got |
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Changes LGTM, but we should get to the bottom of the doxygen issue (which is annoying!).
| Note that this guide covers the most complex case of adding a new function to both | ||
| the C and Python APIs. | ||
|
|
||
| 0. Draft a docstring for your function, that describes exactly what the function |
|
I win? |
|
This passes, though, so I move to merge this, and when/if I figure out what's going on with my local build I'll update things? |
2 participants
I"ve gone through the dev docs and done a lot of the things in them. They are great, thanks @jeromekelleher. I have only minor edits.
However: maybe they need something else, since the docs don't build for me locally? I get