Skip to content

Fix same-net schematic trace hover highlighting#205

Open
RoyZhao1991 wants to merge 1 commit into
tscircuit:mainfrom
RoyZhao1991:codex/trace-hover-net-key
Open

Fix same-net schematic trace hover highlighting#205
RoyZhao1991 wants to merge 1 commit into
tscircuit:mainfrom
RoyZhao1991:codex/trace-hover-net-key

Conversation

@RoyZhao1991
Copy link
Copy Markdown

/claim tscircuit/tscircuit#1130
/fixes tscircuit/tscircuit#1130

Problem

Hovering a schematic trace can fail to highlight other trace segments in the same net because generated schematic_trace elements may not carry subcircuit_connectivity_map_key, so the SVG output gets data-subcircuit-connectivity-map-key="undefined".

Solution

Populate schematic trace connectivity keys before SVG generation by deriving them from direct source_trace_id matches or solver-generated endpoint ids like solver_R1.2-C1.1. This lets the existing circuit-to-svg same-net hover CSS target all connected traces consistently.

Verification

  • npx bun test
  • npx bun run format:check
  • npx bun run build

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-viewer Ready Ready Preview, Comment May 20, 2026 12:29pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change of color on hover for traces are missing

1 participant