Fix same-net schematic trace hover highlighting#205
Open
RoyZhao1991 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim tscircuit/tscircuit#1130
/fixes tscircuit/tscircuit#1130
Problem
Hovering a schematic trace can fail to highlight other trace segments in the same net because generated
schematic_traceelements may not carrysubcircuit_connectivity_map_key, so the SVG output getsdata-subcircuit-connectivity-map-key="undefined".Solution
Populate schematic trace connectivity keys before SVG generation by deriving them from direct
source_trace_idmatches or solver-generated endpoint ids likesolver_R1.2-C1.1. This lets the existing circuit-to-svg same-net hover CSS target all connected traces consistently.Verification
npx bun testnpx bun run format:checknpx bun run build