fix: highlight same-net schematic traces on hover#185
Open
wpearce1 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim tscircuit/tscircuit#1130
/fixes tscircuit/tscircuit#1130
Summary
Adds same-net hover highlighting for schematic traces in
@tscircuit/schematic-viewer.useTraceNetHoverHighlight, using event delegation on the generated SVG.source_netrelationshipsnet.VOUTandnet.GNDfor manual verification.Test plan
npm install --package-lock=false --legacy-peer-deps(local only; repo normally uses Bun but this machine does not havebuninstalled)npx biome format .npx -p typescript@^5.0.0 tsc --noEmitgit diff --checkNotes
The existing open PR #182 appears to group by
source_trace_id; this PR goes a bit broader and unions traces by same-net metadata so separate trace segments connected throughnet.*labels highlight together as requested.