fix: remove duplicate points causing extra trace lines in post-processing#183
Open
inventelpk-cell wants to merge 1 commit intotscircuit:mainfrom
Open
Conversation
…sing Added removeDuplicatePoints() in simplifyPath.ts to strip consecutive identical points (zero-length segments). Applied dedup at splice site in UntangleTraceSubsolver._applyBestRoute() to prevent duplicates introduced during rerouting. Closes tscircuit#78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes extra/overlapping trace lines caused by consecutive duplicate points (zero-length segments) in post-processing.
Root cause:
simplifyPath()merged collinear segments but did not remove consecutive duplicate points_applyBestRoute()inUntangleTraceSubsolverproduced duplicate points when splicing rerouted segmentsFix:
removeDuplicatePoints()insimplifyPath.tsto strip consecutive identical pointsUntangleTraceSubsolver._applyBestRoute()Closes #78
Test plan