fix: clone netMap to prevent extra traces for net-label-only connections#182
Open
inventelpk-cell wants to merge 1 commit intotscircuit:mainfrom
Open
fix: clone netMap to prevent extra traces for net-label-only connections#182inventelpk-cell wants to merge 1 commit intotscircuit:mainfrom
inventelpk-cell wants to merge 1 commit intotscircuit:mainfrom
Conversation
Shallow-clone directConnMap.netMap before passing to ConnectivityMap constructor. Prevents netConnMap.addConnections() from mutating the shared netMap, which caused queuedDcNetIds to include nets with zero direct connections, generating traces for net-label-only connections. Closes tscircuit#79
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where pins connected only via
netConnections(net labels) incorrectly generate physical trace lines.Root cause:
directConnMap.netMapwas passed by reference to theConnectivityMapconstructor fornetConnMap. WhennetConnMap.addConnections()added net-label-only connections, it mutated the sharednetMap, causingqueuedDcNetIdsto include nets with zero direct connections.Fix: Shallow-clone
netMap:new ConnectivityMap({...directConnMap.netMap})Closes #79
Test plan
tsc --noEmit)