fix: reset TraceCleanupSolver internal state between passes (issue #34)#181
Open
lau90eth wants to merge 1 commit intotscircuit:mainfrom
Open
fix: reset TraceCleanupSolver internal state between passes (issue #34)#181lau90eth wants to merge 1 commit intotscircuit:mainfrom
lau90eth wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TraceCleanupSolver was not resetting its internal state between passes, causing non-deterministic behavior — same input could produce different output on each run.
Fix
Restored the original TraceCleanupSolver from upstream
Added a reset() method that clears all temporary state:
pipelineStep → reset to "untangling_traces"
traceIdQueue → rebuilt from input
tracesMap → rebuilt from input
activeSubSolver → set to null
activeTraceId → set to null
solved / failed → reset to false
Scope
✅ Only TraceCleanupSolver.ts modified
✅ No algorithm changes
✅ No pipeline changes
✅ Snapshots updated to match corrected output
❌ No advanced merge / reconstruction (out of scope)
Tests
49 pass, 0 fail
Closes #34