fix: reset TraceCleanupSolver internal state between passes (issue #34)#178
Open
lau90eth wants to merge 11 commits intotscircuit:mainfrom
Open
fix: reset TraceCleanupSolver internal state between passes (issue #34)#178lau90eth wants to merge 11 commits intotscircuit:mainfrom
lau90eth wants to merge 11 commits intotscircuit:mainfrom
Conversation
…circuit#34) - Restored original TraceCleanupSolver from upstream - Added reset() method to clear pipelineStep, traceIdQueue, tracesMap, activeSubSolver and activeTraceId before each new solve pass - Removed out-of-scope POW test and simplified solver rewrite - Updated snapshots to match corrected solver output
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
/claim #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
TraceCleanupSolverwas not resetting its internal state between passes, causing non-deterministic behavior — same input could produce different output on each run.Fix
TraceCleanupSolverfrom upstreamreset()method that clears all temporary state:pipelineStep→ reset to"untangling_traces"traceIdQueue→ rebuilt from inputtracesMap→ rebuilt from inputactiveSubSolver→ set to nullactiveTraceId→ set to nullsolved/failed→ reset to falseScope
TraceCleanupSolver.tsmodifiedTests
49 pass, 0 fail
Closes #34