feat: implement snapping logic and collinear merging phase#176
Open
Puroonjay wants to merge 4 commits intotscircuit:mainfrom
Open
feat: implement snapping logic and collinear merging phase#176Puroonjay wants to merge 4 commits intotscircuit:mainfrom
Puroonjay wants to merge 4 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
I have formatted the entire repository to ensure the Format check passes. The Bun test failure is expected as it is a snapshot mismatch because the new geometry is straighter than the old snapshots. Once these are updated on linux env all the tests will pass |
Author
2026-04-13.00-52-28.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a merging_collinear phase to the TraceCleanupSolver pipeline
Logic: used an epsilon-based snapping pass in simplifyPath to handle coordinate jitter and force alignment. This solves the "staircase" effect mentioned in #34 and purges redundant points
/claim #34