fix: skip wire routing for net-label-only nets (issue #79)#175
Open
LuSrodri wants to merge 1 commit intotscircuit:mainfrom
Open
fix: skip wire routing for net-label-only nets (issue #79)#175LuSrodri wants to merge 1 commit intotscircuit:mainfrom
LuSrodri wants to merge 1 commit intotscircuit:mainfrom
Conversation
Nets connected exclusively via netConnections with an availableNetLabelOrientation (e.g. VCC, GND) are represented by net labels only and should not generate routed wire traces. - MspConnectionPairSolver: filter queuedDcNetIds to exclude label-only nets (no direct-wired pins + has label orientation) - LongDistancePairSolver: apply the same skip logic in the nearest-neighbour candidate loop - Update MspConnectionPairSolver_repro1 expectation (4→2 pairs) and regenerate SVG snapshots for affected examples Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nets connected exclusively via
netConnectionswith a configuredavailableNetLabelOrientation(e.g. VCC, GND) are represented by net labels only and should not generate routed wire traces. Before this fix,MspConnectionPairSolverqueued ALL nets including label-only ones, producing spurious extra trace lines on top of the net labels (as reported in #79).Changes
MspConnectionPairSolver: filterqueuedDcNetIdsto skip nets that have no directly-wired pins AND have a configured label orientation —NetLabelPlacementSolverwill handle those with labels instead of wires.LongDistancePairSolver: apply the same skip logic inside the nearest-neighbour candidate loop so long-distance routing also respects label-only nets.MspConnectionPairSolver_issue79.test.tswith two assertions — the solver doesn't queue VCC/GND, and the full pipeline produces no traces for those nets. UpdateMspConnectionPairSolver_repro1expectation (4→2 pairs, reflecting correct label-only exclusion) and regenerate SVG snapshots for 9 affected examples.Test results
/claim #79