feat: add SameNetSegmentMergingSolver to merge close same-net trace segments#174
Open
LuSrodri wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add SameNetSegmentMergingSolver to merge close same-net trace segments#174LuSrodri wants to merge 1 commit intotscircuit:mainfrom
LuSrodri wants to merge 1 commit intotscircuit:mainfrom
Conversation
Implements a new pipeline phase that finds trace segments on the same net that are close together (within a configurable gapThreshold, default 0.15) and snaps them to align, reducing visual clutter in schematic diagrams. The solver runs after TraceCleanupSolver and before the final NetLabelPlacementSolver pass. It groups traces by net, detects parallel overlapping interior segments within the gap threshold, and iteratively snaps movable segments toward anchored (endpoint) segments or to their weighted-average coordinate. Endpoint segments are never moved. Adds 5 unit tests covering: same-net merging, cross-net isolation, gapThreshold enforcement, anchor preservation, and empty-trace edge case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a new
SameNetSegmentMergingSolverpipeline phase that merges parallel trace segments from the same net when they are within a configurable gap threshold, reducing visual clutter in schematic diagrams.Changes
lib/solvers/SameNetSegmentMergingSolver/SameNetSegmentMergingSolver.ts— new solver that:globalConnNetIdgapThreshold(default 0.15) and snaps them to a span-weighted average coordinatelib/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver.ts— integrates the solver as a new pipeline phase afterTraceCleanupSolver, with a finalNetLabelPlacementSolverre-run using the merged tracestests/solvers/SameNetSegmentMergingSolver/SameNetSegmentMergingSolver.test.ts— 5 unit tests covering: same-net snapping, cross-net isolation, gap threshold enforcement, anchor protection, and solver lifecycleTest results
/claim #34