Increase GLB export board texture resolution from 512 to 1024#3049
Open
mohan-bee wants to merge 2 commits intotscircuit:mainfrom
Open
Increase GLB export board texture resolution from 512 to 1024#3049mohan-bee wants to merge 2 commits intotscircuit:mainfrom
mohan-bee wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rushabhcodes
requested changes
Apr 7, 2026
Contributor
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
can you add before and after for proof in the comment
Contributor
Author
|
i have just added my circuit code in runframe for reproduction: Before: before.movAfter: after.mov |
Contributor
|
We used 512 to fix some user boards that wouldn't export i think CC @imrishabh18 can approve if it probably won't be an issue |
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
@imrishabh18 ready for review ! |
imrishabh18
approved these changes
Apr 12, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
I think this would should be okay now, as there have been other performance improvements on rendering, so increasing the texture resolution won't effect much
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLB exports were forcing boardTextureResolution: 512, which made board textures lose detail; switching to 1024 fixes the missing export content.
https://discord.com/channels/1233487248129921135/1490585777149575168