Skip to content

Exclude PCB notes from generated textures by setting showPcbNotes: false#756

Open
seveibar wants to merge 1 commit intomainfrom
codex/fix-pcb-notes-toggle-visibility
Open

Exclude PCB notes from generated textures by setting showPcbNotes: false#756
seveibar wants to merge 1 commit intomainfrom
codex/fix-pcb-notes-toggle-visibility

Conversation

@seveibar
Copy link
Copy Markdown
Contributor

@seveibar seveibar commented Apr 7, 2026

Motivation

  • Prevent PCB fabrication/annotation notes from being included in generated layer textures and render masks so textures reflect only the intended graphical elements.

Description

  • Pass showPcbNotes: false to drawer.drawElements in multiple texture and layer drawing modules so PCB notes are not rendered into textures.
  • Files changed include copper-text-drawing.ts, create-copper-pour-texture-for-layer.ts, fabrication-note-drawing.ts, silkscreen-drawing.ts, soldermask-drawing.ts, through-hole-drawing.ts, pad-texture.ts, and trace-texture.ts to consistently suppress PCB notes during texture generation.
  • Include the flag for both primary draws and repeated/compensation draws and for the knockout/mask draw paths to ensure complete exclusion.

Testing

  • Ran the project automated test suite with yarn test and the full production build with yarn build, and both completed successfully.

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment Apr 7, 2026 11:21pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant