Exclude PCB notes from generated textures by setting showPcbNotes: false#756
Open
Exclude PCB notes from generated textures by setting showPcbNotes: false#756
showPcbNotes: false#756Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
showPcbNotes: falsetodrawer.drawElementsin multiple texture and layer drawing modules so PCB notes are not rendered into textures.copper-text-drawing.ts,create-copper-pour-texture-for-layer.ts,fabrication-note-drawing.ts,silkscreen-drawing.ts,soldermask-drawing.ts,through-hole-drawing.ts,pad-texture.ts, andtrace-texture.tsto consistently suppress PCB notes during texture generation.Testing
yarn testand the full production build withyarn build, and both completed successfully.Codex Task